Fix integer overflows in the damage shaper #1837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't fail somewhere down the line with this, right? |
|
Based on my testing so far, it doesn’t fail. I tested it with: Rectangle::<i32, Physical>::new((0, 0).into(), (1920, 35791423).into()),
Rectangle::<i32, Physical>::new((100, 100).into(), (800, 600).into()),and Rectangle::<i32, Physical>::new((0, 0).into(), (1920, 1000).into()),
Rectangle::<i32, Physical>::new((0, 35790423).into(), (1920, 1000).into()), |
|
@YaLTeR Does this look good, or is there anything I should update? |
|
I'll leave to smithay maintainers to check; I'm not actually familiar with this code |
|
@Drakulix When you have a moment, could you please take a look at this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1822
Large values such as 1920×35791423 px cause integer overflow. This patch fixes the overflow by using saturating multiplication operations in the damage shaper.